-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alloy-node-bindings
#111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
some other name suggestions
crates/test-utils/Cargo.toml
Outdated
@@ -0,0 +1,22 @@ | |||
[package] | |||
name = "alloy-test-utils" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about the name, because these are not only used for testing, for example run some simulations using anvil.
perhaps alloy-nodes, alloy-node-bindings, alloy-node-commands|cmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crates/test-utils/src/genesis.rs
Outdated
/// fork switch blocks. | ||
#[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq, Eq)] | ||
#[serde(rename_all = "camelCase")] | ||
pub struct Genesis { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these types I wanted to put in its own crate (extracting from reth-primitives)
but for now this is fine
Closes #106
I have not ported Ganache because the Truffle suite has been deprecated: https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat
Removes
ethers-core
from dev-dependencies.